Simplify unfolds by reusing results of predicate verification#929
Merged
Conversation
…n, and reusing them on unfold
…perproject/silicon into meilers_reuse_predicate_heaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify executing
unfolds and evaluatingunfoldings by removing the need to fully produce the predicate body.The idea (thanks @JonasAlaif!) is to reuse the result of verifying the predicate body's well-definedness: After doing so, we know the potential branches and the potential heaps we get from a predicate unfold. Thus, we can remember these heaps, the assumptions that came with them, as well as the declarations we made in the process, and simply declare them, assume them, and add them to our current heap when we are asked to unfold the predicate.
For now, this optimization is disabled by default, and can be turned on by using the new flag
--enableSimplifiedUnfolds.This requires: